fix: patch anoncreds to fix partially deleted creds issue #1999
Conversation
Signed-off-by: Bryce McMath <bryce.j.mcmath@gmail.com>
|
| + relatedCredentialExchangeRecord.setTags({ | ||
| + anonCredsRevocationRegistryId: (0, indyIdentifiers_1.getQualifiedDidIndyDid)(legacyTags.revocationRegistryId, indyNamespace), | ||
| + anonCredsUnqualifiedRevocationRegistryId: (0, indyIdentifiers_1.getUnQualifiedDidIndyDid)(legacyTags.revocationRegistryId), | ||
| + anonCredsUnqualifiedRevocationRegistryId: (0, indyIdentifiers_1.getUnqualifiedRevocationRegistryDefinitionId)(namespaceIdentifier, schemaSeqNo, credentialDefinitionTag, revocationRegistryTag), |
There was a problem hiding this comment.
Should this fix be added to Credo or anoncrets-rs so that we can eventually not relay on the patch?
There was a problem hiding this comment.
It's partly in a PR and partly merged into Credo main after 0.5.3, so will likely make it into Credo 0.5.4 or 0.5.5. I didn't want to wait until then though
|
@bryce-mcmath In the description to you mean 0.4.2 or 0.5.2? What was special about 0.4.3 and after that fixes things? Also, does this fix need to go into |
@jleach 0.4.2 was just the last version of AFJ we used before we upgraded to Credo 0.5.x. I guess more generally I should say, credentials issued in 0.4.x and before, can be successfully deleted after upgrading to 0.5.3 with this patch. This fix is not needed in anoncreds-rs, just in Credo, but the fix for the mobile verifier issue may be required in anoncreds-rs and the wrappers. That's the last outstanding issue with the upgrade AFAIK and Ariel from the Credo team is looking into it. Wade may have already fixed it as well, we'll see after his vdr and anoncreds PRs get merged. |
After this patch, credentials issued in 0.4.2 and before will be successfully deleted in current build