feat: added person credential loading screen #2094
Conversation
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
| @@ -0,0 +1,53 @@ | |||
| import { useTheme } from '@hyperledger/aries-bifold-core' | |||
There was a problem hiding this comment.
Curious if there was a component in Bifold that could just be modified to take in a different graphic?
| setDidCompleteAttestationProofRequest(true) | ||
| } | ||
| }, attestationProofRequestWaitTimeout) | ||
| }, [remoteAgentDetails]) |
There was a problem hiding this comment.
| }, [remoteAgentDetails]) | |
| }, [remoteAgentDetails, receivedProofRequests, attestationProofRequestWaitTimeout, logger]); |
There was a problem hiding this comment.
attestationProofRequestWaitTimeout and logger should be constant for the duration of the screen no? I don't think its possible for either of them to change without reloading the app
| return () => { | ||
| subscriptions.forEach((subscription) => subscription.remove()) | ||
| } | ||
| }, []) |
There was a problem hiding this comment.
I think in this one you may need:
- The navigation object is included in the dependencies array to ensure that the effect re-runs if navigation changes.
- DeviceEventEmitter, BifoldEventTypes, or AttestationEventTypes are constants and do not change, they don't need to be in the dependencies array. If they can change, they should be added to the array as well.
There was a problem hiding this comment.
Not quite sure what you mean with adding the navigation object to the dependancy array. The navigation object should only change when we trigger a navigation event like navigating to a new screen, in which case we wouldn't want to re-run the useEffect because we'd be leaving this screen right?
| goToCredentialOffer(credential.id) | ||
| } | ||
| } | ||
| }, [receivedCredentialOffers, remoteAgentDetails]) |
There was a problem hiding this comment.
maybe store.developer.environment.iasPortalUrl so we're not reacting to every change that happens on the store object? IMHO iasPortalUrl shouldn't be changing while we're on this screen so should we even just treat it as a constant?
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
wadeking98
force-pushed
the
feat-person-loading-screen
branch
from
a1a393c
to
2edf41d
Compare
|
Added loading screen to person credential flow instead of button activity indicator
personLoading.mp4