feat: extend state and move constants #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanji
previously approved these changes
Nov 14, 2022
jleach
force-pushed
the
fix/override-state
branch
from
103ba19
to
e10a8eb
Compare
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
jleach
force-pushed
the
fix/override-state
branch
from
e10a8eb
to
e971f49
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
cvarjao
reviewed
Nov 22, 2022
@cvarjao They match up to bifold package versions. For example, bifold uses 8.1.1 of the keychain but our package was 7.x. |
|
Ok. So not exactly related, but an opportunity to get them back in sync. LGTM |
cvarjao
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the new extensible state mechanics of Bifold to add our own custom
developerstate. Included are moving some of the constants used by BCIDView such as the URLs and invitation ID. They will be editable in the eminent Developer screen so this is where they should live rather that a constants file.Depends on 514.