Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added custom notifications to bcwallet #833

Merged
merged 6 commits into from
Jan 20, 2023

Conversation

wadeking98
Copy link
Contributor

Added custom notification for BCID Person credential:
image
image

Signed-off-by: wadeking98 wkingnumber2@gmail.com

Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
app/src/store.tsx Outdated Show resolved Hide resolved
app/src/index.ts Show resolved Hide resolved
app/src/screens/Splash.tsx Outdated Show resolved Hide resolved
app/src/screens/Splash.tsx Outdated Show resolved Hide resolved
app/src/index.ts Outdated Show resolved Hide resolved
app/src/screens/PersonCredential.tsx Outdated Show resolved Hide resolved
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
jleach
jleach previously approved these changes Jan 20, 2023
Copy link
Member

@jleach jleach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments for consideration. Your call what to do with 'em.

app/src/screens/Splash.tsx Outdated Show resolved Hide resolved
app/src/screens/Splash.tsx Show resolved Hide resolved
@jleach
Copy link
Member

jleach commented Jan 20, 2023

@wadeking98 Sorry about the merge conflict. Looks like my previous PR conflicted with this one. Looked kind of big. Might be easier to the the file from main and just copy-paste your changes into it.

… feat-custom-notifications

Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wadeking98 wadeking98 merged commit 6639a06 into bcgov:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants