Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated new openvp branding in bc wallet #855

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

wadeking98
Copy link
Contributor

@wadeking98 wadeking98 commented Jan 27, 2023

Signed-off-by: wadeking98 wkingnumber2@gmail.com
Resolves: #806
Added new openvp schemas to credential branding as per this discussion:
#506

Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
@wadeking98 wadeking98 force-pushed the feat-update-openvp-cred-branding branch from e47cfe5 to c413141 Compare January 27, 2023 18:29
Copy link
Member

@cvarjao cvarjao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resole conflicts. Can we also delete the _OLD which are non unused references? we can always bring them back from git history

… feat-update-openvp-cred-branding

Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wadeking98 wadeking98 merged commit a078b01 into bcgov:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update credential branding for Unverified Person Credential
3 participants