Made Person credential screen scrollable #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanji
suggested changes
Jan 30, 2023
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
wadeking98
force-pushed
the
fix-person-screen-scrollable
branch
from
7e4adf0
to
f01f9e4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Figured it out, I needed to add |
amanji
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wadeking98 wkingnumber2@gmail.com
Made Person Credential screen scrollable to allow users to access buttons with large text size
In the demo below, I've added a few buttons to demonstrate scrolling since I can't reproduce the issue on my device.
Screencast from 2023-01-30 08:45:49 AM.webm
Resolves: #858
Note: I've removed the safeAreaView. I couldn't figure out how to make it work with the scrollView. Something about the
contentContainerStyleattribute meant that if I displayed the scrollView in the safeAreaView then the content would be blank. I see in other parts of the codebase that we have un-nested scrollViews so I figured it would be okay here