feat: separated events from react state #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadeking98
force-pushed
the
feat-event-framework
branch
2 times, most recently
from
182665e
to
8c5b69a
Compare
This was referenced Feb 13, 2023
wadeking98
force-pushed
the
feat-event-framework
branch
from
8c5b69a
to
36e545a
Compare
wadeking98
force-pushed
the
feat-event-framework
branch
from
36e545a
to
7749981
Compare
|
Depends on bifold submodule update |
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
wadeking98
force-pushed
the
feat-event-framework
branch
2 times, most recently
from
36dfdbf
to
ee340c5
Compare
… feat-event-framework Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
jleach
requested changes
Feb 18, 2023
… feat-event-framework Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
wadeking98
force-pushed
the
feat-event-framework
branch
from
8c4a313
to
24f6c50
Compare
|
Are you running the linter + prettier? |
|
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
wadeking98
force-pushed
the
feat-event-framework
branch
from
24f6c50
to
04f4496
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
okay I've updated with linting completed |
I think it should, you just might have to run |
bryce-mcmath
approved these changes
Feb 22, 2023
jleach
approved these changes
Feb 28, 2023
|
@wadeking98 Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wadeking98 wkingnumber2@gmail.com
Moved events from react state to DeviceEventEmitter