chore: configure linting, hooks, jest, run lint #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryce McMath <bryce.j.mcmath@gmail.com>
Signed-off-by: Bryce McMath <bryce.j.mcmath@gmail.com>
bryce-mcmath
requested review from
wadeking98,
jleach and
amanji
and removed request for
jleach
amanji
previously approved these changes
Feb 16, 2023
Signed-off-by: Bryce McMath <32586431+bryce-mcmath@users.noreply.github.com>
amanji
reviewed
Feb 21, 2023
Signed-off-by: Bryce McMath <bryce.j.mcmath@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
amanji
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git hooks are now functioning as they are in bifold, the linter did catch quite a few issues so I made those changes. Jest is setup but only one test is running as it has trouble running tests of components that import from Bifold, so I'm gonna leave that ticket for someone else to take a swing at. I had to add a rule to the BC Wallet eslint config that isn't present in the bifold config, the rule to make unused-vars an error and not just a warning. This matches the behavior in bifold (not sure why bifold didn't need to explicitly state the rule.) You may need to run
npx husky@7.0.0 installin the root once to get hooks working for you. Alternatively you can use the newsetupscript in thepackage.json, it does the same thing.Apologies for touching so many files.
Blocked By