fix: prevent back nav to splash page, run lint #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryce McMath <bryce.j.mcmath@gmail.com>
bryce-mcmath
requested review from
jleach,
amanji and
wadeking98
and removed request for
jleach
jleach
requested changes
Mar 2, 2023
| @@ -204,22 +205,42 @@ const Splash: React.FC = () => { | |||
| }) | |||
|
|
|||
| if (onboardingComplete(dataAsJSON) && !attemptData?.lockoutDate) { | |||
| navigation.navigate(Screens.EnterPIN as never) | |||
| navigation.dispatch( | |||
| CommonActions.reset({ | |||
There was a problem hiding this comment.
Cool. Didn't know we could do this.
There was a problem hiding this comment.
Yeah it's pretty handy! Took some researching to find how to do it
Signed-off-by: Bryce McMath <bryce.j.mcmath@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
jleach
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resetting the nav stack whenever the splash page is navigated from, this PR in combination with openwallet-foundation/bifold-wallet#647 should fix the majority of the back navigating issues we have been having with the iOS swipe-back and the Android hardware back button.
I also ran the linter and made the changes it demanded. In most cases where there were unused variables/imports I simply commented them out since you may want them for reference.