Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bcdc_get_data and bcdc_query_geodata to work on full url with resource #125

Closed
ateucher opened this issue Nov 1, 2019 · 0 comments · Fixed by #196
Closed

Allow bcdc_get_data and bcdc_query_geodata to work on full url with resource #125

ateucher opened this issue Nov 1, 2019 · 0 comments · Fixed by #196
Milestone

Comments

@ateucher
Copy link
Collaborator

ateucher commented Nov 1, 2019

e.g., https://catalogue.data.gov.bc.ca/dataset/current-provincial-electoral-districts-of-british-columbia/resource/89de1e77-9e33-41dd-bf6f-34e6d664b89a.

Should be a simple matter of detecting it (grepping for /resource/ and splitting it into record and resource id - an extension of

bcdata/R/utils.R

Lines 67 to 70 in c255edc

slug_from_url <- function(x) {
if (grepl("^(http|www)", x)) x <- basename(x)
x
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant