Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BBOX() not including geometry column name #135

Closed
ateucher opened this issue Nov 13, 2019 · 0 comments · Fixed by #137
Closed

BBOX() not including geometry column name #135

ateucher opened this issue Nov 13, 2019 · 0 comments · Fixed by #137
Labels
bug Something isn't working wfs
Milestone
0.1.2

Comments

@ateucher
Copy link
Collaborator

This fails:

library(bcdata)
#> 
#> Attaching package: 'bcdata'
#> The following object is masked from 'package:stats':
#> 
#>     filter
bcdc_query_geodata("WHSE_FOREST_VEGETATION.BEC_BIOGEOCLIMATIC_POLY", crs = 4326) %>% 
  filter(BBOX(c(1639473.0,528785.2,1665979.9,541201.0))) %>% 
  show_query()
#> <url>
#> <body>
#>    SERVICE: WFS
#>    VERSION: 2.0.0
#>    REQUEST: GetFeature
#>    outputFormat: application/json
#>    typeNames: WHSE_FOREST_VEGETATION.BEC_BIOGEOCLIMATIC_POLY
#>    SRSNAME: EPSG:4326
#>    CQL_FILTER: (BBOX((1639473.0, 528785.2, 1665979.9, 541201.0)))
#> 
#> <full query url>
#> https://openmaps.gov.bc.ca/geo/pub/wfs?SERVICE=WFS&VERSION=2.0.0&REQUEST=GetFeature&outputFormat=application%2Fjson&typeNames=WHSE_FOREST_VEGETATION.BEC_BIOGEOCLIMATIC_POLY&SRSNAME=EPSG%3A4326&CQL_FILTER=%28BBOX%28%281639473.0%2C%20528785.2%2C%201665979.9%2C%20541201.0%29%29%29

Because it should be BBOX(the_geom, 1639473.0, 528785.2, 1665979.9, 541201.0)
@ateucher ateucher added bug Something isn't working wfs labels Nov 13, 2019
@ateucher ateucher added this to the 0.1.2 milestone Nov 13, 2019
ateucher added a commit that referenced this issue Nov 14, 2019
@ateucher
Add test to ensure BBOX works (#135)
7d70497
ateucher added a commit that referenced this issue Nov 14, 2019
@ateucher
Add BBOX to list of sql_translator functions
bdb3374 
- ensure all sql_translator functions are properly specified
#135
@ateucher ateucher mentioned this issue Nov 14, 2019
Merged
ateucher added a commit that referenced this issue Nov 14, 2019
@ateucher
Merge pull request #137 from bcgov/bbox-fix
64f1ce4 
BBOX fix. Closes #135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working wfs
Projects
None yet
Milestone
0.1.2
Development

Successfully merging a pull request may close this issue.

BBOX fix bcgov/bcdata
1 participant
@ateucher