Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select.bcdc_promise does not work on named variables #138

Closed
hgriesbauer opened this issue Nov 14, 2019 · 1 comment
Closed

select.bcdc_promise does not work on named variables #138

hgriesbauer opened this issue Nov 14, 2019 · 1 comment
Labels
bug Something isn't working catalogue wfs
Milestone

Comments

@hgriesbauer
Copy link
Contributor

The 'record' name returned by bcdc_search() doesn't seem to work in bcdc_query_geodata() in certain cases. For example, this fails:

bcdc_search("Silviculture")%>%
.[5]%>% # select 'results-planting'
names() %>% # get name
bcdc_query_geodata() # pass to query

This also fails:
bcdc_query_geodata("results-planting")

However, the code works if I use the actual object name from the catalogue ("WHSE_FOREST_VEGETATION.RSLT_FOREST_COVER_SILV_SVW"):

bcdc_query_geodata("WHSE_FOREST_VEGETATION.RSLT_FOREST_COVER_SILV_SVW")

Am I doing something wrong, or have I missed something in the instructions? Thanks!

@ateucher
Copy link
Collaborator

ateucher commented Nov 14, 2019

Thanks for reporting this @hgriesbauer. I think it's due to an internal inconsistency in the way the record is formatted - there is a layer_name field and an object_name field, and it seems that it is not consistent which one to use in the WFS call...

Related to #129

@ateucher ateucher added bug Something isn't working catalogue wfs labels Nov 14, 2019
@ateucher ateucher added this to the 0.1.2 milestone Nov 14, 2019
@ateucher ateucher changed the title Record issue using bcdc_query select.bcdc_promise does not work on named variables Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working catalogue wfs
Projects
None yet
Development

No branches or pull requests

2 participants