Get typeName for wfs from resource url #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ateucher
changed the title
ateucher
changed the title
boshek
approved these changes
Nov 15, 2019
|
I'd say merge and handle #133 in another PR. I think some slightly modification to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than pull the layer name to pass to the
typeNamesparameter in the WFS request, this gets it from the url of the wfs resource. This is because records have both alayer_nameand anobject_nameand you can't count on the wfs/wms to use a particular one. See #138 and #129.I also added a new test file for these kinds of edge cases.
One more thing that could be added to this PR is fixing #133, as it is related.