Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbplyr 2.0 release - DBI S4 methods #225

Closed
ateucher opened this issue Sep 29, 2020 · 3 comments
Closed

dbplyr 2.0 release - DBI S4 methods #225

ateucher opened this issue Sep 29, 2020 · 3 comments
Assignees
@ateucher
Labels
in-progress maintenance

Comments

@ateucher
Copy link
Collaborator

ateucher commented Sep 29, 2020 •
edited
Loading

From https://github.com/tidyverse/dbplyr/blob/master/NEWS.md: DBI::dbQuoteIdentifier() is now used instead of sql_escape_ident() andDBI::dbQuoteString() instead of sql_escape_string().

Requires importing DBI and new S4 methods for those DBI generics. Some initial guidance here: https://dbplyr.tidyverse.org/dev/articles/backend-2.html. I think those are the only changes that impact bcdata
@ateucher ateucher self-assigned this Sep 29, 2020
ateucher added a commit that referenced this issue Sep 29, 2020
@ateucher
Add S4 methods for dbQuoteIdentifier and dbQuoteString #225
8e7f942
ateucher added a commit that referenced this issue Sep 29, 2020
@ateucher
Install dev dbplyr to check #225
34afabb
@ateucher ateucher mentioned this issue Sep 29, 2020
Merged
@ateucher ateucher changed the title prepare for dbplyr 2.0 release dbplyr 2.0 release - DBI S4 methods Sep 29, 2020
@ateucher
Copy link
Collaborator Author

Looks like there might also need to be a change to sql_translate_env: tidyverse/dbplyr#385 (comment)

ateucher added a commit that referenced this issue Sep 29, 2020
@ateucher
Merge pull request #226 from bcgov/dbplyr-fixes
07cbe84 
Dbplyr fixes address #225
@ateucher
Copy link
Collaborator Author

ateucher commented Oct 1, 2020

sql_translate_env -> sql_translation here: tidyverse/dbplyr@be9b1aa

ateucher added a commit that referenced this issue Oct 22, 2020
@ateucher
Add TODOs for dbplyr 2.0+, #225
9808705
@ateucher
Copy link
Collaborator Author

ateucher commented Jul 5, 2022

Closed by #300

@ateucher ateucher closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ateucher ateucher

Labels
in-progress maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ateucher