Enable catalogue authorization #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- split bcdc_http_client into wfs and catalogue - access BCDC_KEY env var for authorization of catalogue requests - add tests
|
Also, that error on Actions on R 3.5 is from rmarkdown - they know about it and should be fixed next release... rstudio/rmarkdown#1832 |
stephhazlitt
approved these changes
Jun 4, 2020
boshek
approved these changes
Jun 4, 2020
stephhazlitt
reviewed
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal implementation, allowing a user to store their catalogue API key in their .Renviron file as
BCDC_KEY.This allows searching and retrieving records and data from the catalogue which are not public/published (but they are authorized for in the catalogue) - e.g., DRAFT records.