Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against check failures in examples #229

Merged
merged 8 commits into from
Oct 22, 2020
Merged

Guard against check failures in examples #229

merged 8 commits into from
Oct 22, 2020

Conversation

ateucher
Copy link
Collaborator

@ateucher ateucher commented Oct 20, 2020 •
edited by boshek
Loading

Set up GH Actions to run the examples that are wrapped in donttest{}

Files to be checked for examples that hit the web services, and wrap those in try():

  • bcdata-package.R
  • bcdc_browse.R
  • bcdc_options.R
  • bcdc_search.R
  • bcdc-web-services.R
  • cql-geom-predicates.R
  • cql-translator.R
  • describe-feature.R
  • get_data.R
  • utils-as_tibble.R
  • utils-classes.R
  • utils-collect.R
  • utils-filter.R
  • utils-is.R
  • utils-mutate.R
  • utils-pipe.R
  • utils-select.R
  • utils-show-query.R
  • utils.R
  • zzz.R

@boshek
Copy link
Collaborator

boshek commented Oct 21, 2020

/document

@ateucher
Copy link
Collaborator Author

Is this all done then do you think @boshek? Just a NEWS item?

@boshek
Copy link
Collaborator

boshek commented Oct 21, 2020

Yeah I think so!

@boshek boshek marked this pull request as ready for review October 21, 2020 22:36
@ateucher ateucher merged commit d780f10 into master Oct 22, 2020
@ateucher ateucher mentioned this pull request Oct 22, 2020
Closed
@boshek boshek deleted the fix-examples-checks branch December 4, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boshek boshek boshek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ateucher @boshek