-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract download limits directly from WFS #256
Conversation
@ateucher any thoughts on how to test to see if one can change an option if it is set by package load? I tried this: bcdata/tests/testthat/test-options.R Lines 37 to 41 in 919333c
But that doesn't seem to stick. |
Co-authored-by: Andy Teucher <andy.teucher@gov.bc.ca>
Sorry, I didn't look closely enough at your approach... What if we did this:
This allows a user to set the option, but if they don't we have a safe default - and someone couldn't inadvertently unset it (e.g., with This would also allow us to check a user's set option against the catalogue's hard cap and throw an error if it's higher... |
This PR:
bcdc_single_download_limit
functionNot yet implemented:
- A test that makes sure one can reset that option.