Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create paginated only print msg #264

Merged
merged 6 commits into from
Apr 13, 2021
Merged

create paginated only print msg #264

merged 6 commits into from
Apr 13, 2021

Conversation

boshek
Copy link
Collaborator

@boshek boshek commented Apr 12, 2021 •
edited
Loading

Closes #240

@boshek boshek requested a review from ateucher April 12, 2021 20:52
@ateucher
Copy link
Collaborator

ateucher commented Apr 12, 2021 •
edited
Loading

Looks nice! I also wondered about using number_of_records in the collect.bcdc_promise() message here

ateucher
ateucher approved these changes Apr 12, 2021
View reviewed changes
R/utils-classes.R Outdated Show resolved Hide resolved
boshek and others added 2 commits April 12, 2021 15:19
@boshek
Copy link
Collaborator Author

boshek commented Apr 12, 2021

Great idea @ateucher. Can you just confirm that is about what you meant?

ateucher
ateucher reviewed Apr 12, 2021
View reviewed changes
R/utils-classes.R Outdated Show resolved Hide resolved
boshek and others added 3 commits April 12, 2021 15:34
@boshek boshek merged commit 95cf896 into master Apr 13, 2021
@boshek boshek deleted the paginate-msg branch April 13, 2021 05:25
This was referenced Apr 13, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ateucher ateucher ateucher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide information on filesize/expected download time
2 participants
@boshek @ateucher