Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change download_audience default to NULL and quote facet values for bcdc_search() (#315) #316

Merged
merged 16 commits into from
Mar 11, 2023
Merged

Change download_audience default to NULL and quote facet values for bcdc_search() (#315) #316

merged 16 commits into from
Mar 11, 2023

Conversation

stephhazlitt
Copy link
Member

@stephhazlitt stephhazlitt commented Mar 3, 2023 •
edited
Loading

An attempt to address #315

@stephhazlitt stephhazlitt requested review from ateucher and boshek and removed request for ateucher and boshek March 3, 2023 05:50
boshek
boshek requested changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@boshek boshek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we should figure out some way of making what this change is doing either by a comment or some re-arranging of code.

R/bcdc_search.R Outdated Show resolved Hide resolved
boshek
boshek approved these changes Mar 5, 2023
View reviewed changes
R/utils.R Outdated Show resolved Hide resolved
R/bcdc_search.R Show resolved Hide resolved
R/bcdc_search.R Outdated Show resolved Hide resolved
ateucher
ateucher approved these changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@ateucher ateucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and sorry for the delay! One very minor suggestion...

R/bcdc_search.R Outdated Show resolved Hide resolved
ateucher
ateucher reviewed Mar 8, 2023
View reviewed changes
R/bcdc_search.R Outdated Show resolved Hide resolved
stephhazlitt and others added 4 commits March 8, 2023 22:01
@stephhazlitt stephhazlitt merged commit 52dce66 into main Mar 11, 2023
@stephhazlitt stephhazlitt mentioned this pull request Mar 11, 2023
Closed
@ateucher ateucher mentioned this pull request Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ateucher ateucher ateucher approved these changes

@boshek boshek boshek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephhazlitt @ateucher @boshek