Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update catalogue #343

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Update catalogue #343

wants to merge 11 commits into from
+262 −112

Conversation

boshek
Copy link
Collaborator

@boshek boshek commented Jul 9, 2024

Testing #342

ateucher
ateucher reviewed Jul 9, 2024
View reviewed changes
R/utils.R Show resolved Hide resolved
@ateucher
Copy link
Collaborator

ateucher commented Aug 16, 2024 •
edited
Loading

So... this is passing now with a couple of (rather big) caveats:

  1. I've skipped tests for which there is no available data in tests/test-get-data.R.
  2. The new catalogue requires a new API key, which I can't get since I don't have an IDIR. Right now I've disabled the BCDC_KEY environment variable in the R CMD check action so the tests that access private records are skipped. We could continue this way or @stephhazlitt could get a key from the new catalogue and we can add that to the repo secrets. Or we could ask the catalogue team for a different key for CI purposes.

@stephhazlitt
Copy link
Member

@ateucher I'll chat with the catalogue team next week re: best path for the API key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ateucher ateucher ateucher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boshek @ateucher @stephhazlitt