Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17124 + 16550 - Vue3 upgrade: Upgrade a component + Storybook #204

Merged
merged 3 commits into from
Nov 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ module.exports = {
'eslint:recommended',
'plugin:@typescript-eslint/recommended',
'plugin:vue/base',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Vue2 specific plugins

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these for Vue2 only, or did they bring value for Vue3 code?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there updated plugins for Vuetify 3?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the documentation again vue/base should be included. No updates for Vuetify 3

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

'plugin:vue/essential',
'plugin:vue/recommended',
'plugin:vue/strongly-recommended',
'plugin:vue/vue3-essential',
'plugin:vue/vue3-recommended',
'plugin:vue/vue3-strongly-recommended',
Expand Down
35 changes: 17 additions & 18 deletions .storybook/main.ts
Original file line number Diff line number Diff line change
@@ -1,29 +1,28 @@
const path = require('path')
import type { StorybookConfig } from '@storybook/vue-vite'
import type { StorybookConfig } from '@storybook/vue3-vite'

const config: StorybookConfig = {
framework: {
name: '@storybook/vue-vite',
name: '@storybook/vue3-vite',
options: {}
},
core: {
builder: '@storybook/builder-vite',
disableTelemetry: true
},
stories: ["../src/**/*.stories.@(js|jsx|ts|tsx)"],
addons: [
{
name: "@storybook/addon-essentials",
options: {
actions: false,
backgrounds: true,
controls: true,
docs: false,
viewport: true,
toolbars: false
}
addons: [{
name: "@storybook/addon-essentials",
options: {
actions: false,
backgrounds: true,
controls: true,
docs: false,
viewport: true,
toolbars: false
}
]
}

export default config
}],
docs: {
autodocs: false
}
};
export default config;
43 changes: 17 additions & 26 deletions .storybook/preview.ts
Original file line number Diff line number Diff line change
@@ -1,32 +1,23 @@
import 'core-js/stable' // to polyfill ECMAScript features
import 'regenerator-runtime/runtime' // to use transpiled generator functions
import '@mdi/font/css/materialdesignicons.min.css' // ensure you are using css-loader
import Vue from 'vue'
import Vue2Filters from 'vue2-filters'
import Vuelidate from 'vuelidate'
import Vuetify from 'vuetify'
import 'vuetify/dist/vuetify.min.css'
import { Preview } from '@storybook/vue'
import { setup } from '@storybook/vue3';
import type { App } from 'vue'
import '@/assets/styles/base.scss'
import '@/assets/styles/layout.scss'
import '@/assets/styles/overrides.scss'

Vue.use(Vue2Filters) // needed by SbcFeeSummary
Vue.use(Vuelidate) // needed by BaseAddress
Vue.use(Vuetify)
import vuetify from '../src/plugins/vuetify'

const preview: Preview = {
decorators: [
(story) => ({
components: { story },
vuetify: new Vuetify({ iconfont: 'mdi' }),
template: `
<v-app class="app-container theme--light">
<story />
</v-app>
`
})
]
}
setup((app:App) => {
app.use(vuetify)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New way of using vuetify ;)

})

export default preview
// you can define global your Vuetify decorators
export const decorators = [
(story: any) => ({
components: { story },
template: `
<v-app class="app-container theme--light">
<story />
</v-app>
`
})
]
Loading