Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18722 Update foreign company error messages #599

Merged
merged 1 commit into from
Dec 18, 2023
Merged

18722 Update foreign company error messages #599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/components/Amalgamation/AmalgamatingBusinesses.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
v-model="legalName"
filled
label="Business' full legal name in home jurisdiction"
:rules="foreignBusinessRules"
:rules="foreignBusinessLegalNameRules"
/>
</v-col>
<v-col
Expand All @@ -124,7 +124,7 @@
v-model="corpNumber"
filled
label="Corporate number in home jurisdiction"
:rules="foreignBusinessRules"
:rules="foreignBusinessCorpNumberRules"
/>
</v-col>
<v-col
Expand Down Expand Up @@ -236,8 +236,12 @@ export default class AmalgamatingBusinesses extends Mixins(AmalgamationMixin, Co
isAddingAmalgamatingForeignBusiness = false

/** TextField rules for "Add an Amalgamating Foreign Business" Panel. */
get foreignBusinessRules (): Array<(v) => boolean | string> {
return [ v => !!v || 'Required.' ]
get foreignBusinessLegalNameRules (): Array<(v) => boolean | string> {
return [ v => !!v || 'Full legal name is required' ]
}

get foreignBusinessCorpNumberRules (): Array<(v) => boolean | string> {
return [ v => !!v || 'Corporate number is required' ]
}

/** Called when Jurisdiction menu item is changed. */
Expand Down Expand Up @@ -362,7 +366,7 @@ export default class AmalgamatingBusinesses extends Mixins(AmalgamationMixin, Co
this.legalName &&
this.corpNumber
)
this.jurisdictionErrorMessage = this.jurisdiction ? '' : 'Required.'
this.jurisdictionErrorMessage = this.jurisdiction ? '' : 'Home jurisdiction is required'
this.$refs.foreignBusinessForm.validate()
}

Expand Down
Loading