19561 corpNumber to identifier in foreign amalgamating business #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
Temporary Url for review: https://business-create-dev--pr-644-nq6dlj73.web.app |
| // no auth info and business info means foreign, otherwise LEAR (affiliated or non-affiliated) | ||
| if (!tingBusiness.authInfo && !tingBusiness.businessInfo) { | ||
| // check if foreign | ||
| if (item.foreignJurisdiction) { |
There was a problem hiding this comment.
I think I like this.
Can you remove the comment on line 301 now?
There was a problem hiding this comment.
Karim, this should work, right?
| legalName: item.legalName, | ||
| foreignJurisdiction: item.foreignJurisdiction | ||
| } as AmalgamatingBusinessIF | ||
| } else { | ||
| const tingBusiness = await this.fetchAmalgamatingBusinessInfo(item.identifier) |
There was a problem hiding this comment.
This assumes that all business info is successfully fetched but that's probably OK.
severinbeauvais
approved these changes
Feb 1, 2024
JazzarKarim
pushed a commit
to JazzarKarim/business-create-ui
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#19561
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).