19774 Fixed null officer email schema error #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- delete officer email if it's null
severinbeauvais
requested review from
JazzarKarim,
vysakh-menon-aot,
ketaki-deodhar,
jamespaologarcia and
PaulGarewal
JazzarKarim
approved these changes
Feb 8, 2024
vysakh-menon-aot
approved these changes
Feb 8, 2024
severinbeauvais
commented
Feb 8, 2024
| */ | ||
| fixNullAddressType (orgPeople: OrgPersonIF[]): OrgPersonIF[] { | ||
| return orgPeople.map(p => { | ||
| if (p.deliveryAddress?.addressType === null) delete p.deliveryAddress.addressType | ||
| if (p.mailingAddress?.addressType === null) delete p.mailingAddress.addressType | ||
| if (p.officer?.email === null) delete p.officer.email |
There was a problem hiding this comment.
Party schema shows this:
JSON schema reference shows this (so I don't have to delete email if it's an empty string):
|
After this change, you can see that parties[0].officer and parties[3].officer have an email property but the other 2 don't. This passes schema validation.
|
|
/gcbrun |
|
Temporary Url for review: https://business-create-dev--pr-651-pp38jdpg.web.app SB says, try this: https://business-create-dev--pr-651-pp38jdpg.web.app/amalg-short-review-confirm?id=TNVSuDNaw6&accountid=2288 |
JazzarKarim
pushed a commit
to JazzarKarim/business-create-ui
that referenced
this pull request
Feb 23, 2024
- delete officer email if it's null Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#19774
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).