19745 Implemented compatible entity type check for adoptee businesses #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severinbeauvais
force-pushed
the
19745
branch
from
a90303a to
ab89ad9
Compare
- imported updated correct-name shared component - now filter adoptee businesses here instead of in shared component - added filter for entity type - added test suite
severinbeauvais
force-pushed
the
19745
branch
from
ab89ad9 to
9e29228
Compare
severinbeauvais
changed the title
|
/gcbrun |
|
Temporary Url for review: https://business-create-dev--pr-654-90fblr75.web.app SB says, try this: https://business-create-dev--pr-654-90fblr75.web.app/amalg-reg-information?id=TaUQpULq2Z&accountid=3040 |
Before (ie, in Dev):
After (ie, in preview site):
|
When there are no compatible TING businesses to adopt the name from:
|
vysakh-menon-aot
approved these changes
Feb 13, 2024
ketaki-deodhar
approved these changes
Feb 13, 2024
JazzarKarim
pushed a commit
to JazzarKarim/business-create-ui
that referenced
this pull request
Feb 23, 2024
- imported updated correct-name shared component - now filter adoptee businesses here instead of in shared component - added filter for entity type - added test suite Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#19745
Description of changes:
- app version = 5.8.14
- imported updated correct-name shared component
- now filter adoptee businesses here instead of in shared component
- added filter for entity type
- added test suite
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).