19874 Changed some snackbar messages to dialogs #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 16, 2024 15:27
- used error dialog for "business not in LEAR" scenario - used error dialog for "unable to add business" scenario - used error dialog for "error marking new business" scenario - bolded labels in RegistriesContactInfo component - added generic error dialog component
- update unit tests
severinbeauvais
requested review from
jamespaologarcia,
ketaki-deodhar and
PaulGarewal
severinbeauvais
commented
Feb 17, 2024
| @@ -305,6 +315,9 @@ export default class AmalgamatingBusinesses extends Mixins(AmalgamationMixin, Co | |||
| allOk = false | |||
| snackbar = false | |||
| snackbarText = '' | |||
| errorDialog = false | |||
| errorDialogText = undefined as string | |||
| errorDialogTitle = undefined as string | |||
There was a problem hiding this comment.
If I used "null" here, the dialog didn't use its default prop values. This works.
severinbeauvais
commented
Feb 17, 2024
There was a problem hiding this comment.
See ticket for example.
There was a problem hiding this comment.
Yes, this affects every usage of this component, but this is the new UI design.
severinbeauvais
commented
Feb 17, 2024
There was a problem hiding this comment.
See ticket for examples.
severinbeauvais
commented
Feb 17, 2024
|
|
||
| expect(wrapper.emitted('close')).toBeUndefined() | ||
| await wrapper.find('.v-btn').trigger('click') | ||
| expect(wrapper.emitted('close')).toEqual([[]]) |
There was a problem hiding this comment.
This is what gets emitted if you don't emit a value.
|
/gcbrun |
|
Temporary Url for review: https://business-create-dev--pr-660-bm23wsrw.web.app |
JazzarKarim
pushed a commit
to JazzarKarim/business-create-ui
that referenced
this pull request
Feb 23, 2024
* - app version = 5.9.5 - used error dialog for "business not in LEAR" scenario - used error dialog for "unable to add business" scenario - used error dialog for "error marking new business" scenario - bolded labels in RegistriesContactInfo component - added generic error dialog component * - created test suite for new dialog * - rename dialog message -> text - update unit tests --------- Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#19874
Description of changes:
- app version = 5.9.5
- used error dialog for "business not in LEAR" scenario
- used error dialog for "unable to add business" scenario
- used error dialog for "error marking new business" scenario
- bolded labels in RegistriesContactInfo component
- added generic error dialog component
- created test suite for new dialog
- updated unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).