20148 Updated to accommodate alternate name changes #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JazzarKarim
commented
Apr 2, 2024
src/enums/nameType.ts
Outdated
| @@ -0,0 +1,4 @@ | |||
| export enum NameType { | |||
There was a problem hiding this comment.
I wonder if it's worth it moving this enum to the shared components. I'm probably going to have it in Edit UI as well. Thoughts?
There was a problem hiding this comment.
Using the shared enum now!
|
/gcbrun |
|
Temporary Url for review: https://business-create-dev--pr-671-lfa79xqq.web.app |
JazzarKarim
requested review from
severinbeauvais,
argush3,
leodube-aot and
tshyun24
severinbeauvais
approved these changes
Apr 3, 2024
leodube-aot
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#20148
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).