21310 Implement Authorization Date min date validation #701
Conversation
- added Authorization Date min date validation
| this.getExistingBusinessInfo.homeIncorporationDate || | ||
| null | ||
| ) | ||
| } |
There was a problem hiding this comment.
Fall back to null because 'undefined' is not reactive (ie, getters and watchers won't recognize its change).
| @@ -132,7 +132,7 @@ | |||
| sm="9" | |||
| > | |||
| <v-text-field | |||
| v-model="business.homeIdentifier" | |||
| v-model.trim="business.homeIdentifier" | |||
There was a problem hiding this comment.
This modifier automatically trims leading and trailing spaces. (Note: on screen, it looks like there are trailing spaces, but in the variable itself, those spaces aren't there.)
Ref: https://vuejs.org/guide/essentials/forms#trim
cc: @JazzarKarim
- now deep-watch objects
| (v) => !!v || 'Identifying Number is required', | ||
| (v) => (v && v.length <= 50) || 'Cannot exceed 50 characters' | ||
| (v) => !!v?.trim() || 'Identifying Number is required', | ||
| (v) => (v && v.trim().length <= 50) || 'Cannot exceed 50 characters' |
There was a problem hiding this comment.
Apparently, Vuetify doesn't trim the value before applying the rules, so trim() is needed here to determine if the value is falsy (including empty string) and to corrrectly check its length.
| @@ -640,10 +640,8 @@ export default class ExtraproRegistration extends Mixins(DateMixin) { | |||
|
|
|||
| /** Emits form validity. */ | |||
| @Watch('isBusinessActive') | |||
| @Watch('business.homeJurisdiction') | |||
| @Watch('business.homeIncorporationDate') | |||
| @Watch('business', { deep: true }) | |||
There was a problem hiding this comment.
The old code assumed the form validity would change and catch any data changes, but that's incorrect. For example, I could change a home identifier or home legal name character and the form validity wouldn't change, and also line 649 wouldn't be called, so the page wouldn't warn you if you tried to leave with unsaved changes.
Instead of adding those extra watchers, in the new code I simply deep-watch the object (ie, all properties). The downside is that this code is called every time a character changes, but the performance hit is not noticeable.
cc: @JazzarKarim
|
/gcbrun |
|
Temporary Url for review: https://business-create-dev--pr-701-1jrgf7gx.web.app |
Issue #: bcgov/entity#21310
Description of changes:
Commit 1:
Commit 2:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).
Screenshots:
Minimum date is May 16, 2001 because that's the date of registration in BC.
Minimum date is Jan 15, 20024 because that's the date of incorporation in home jurisdiction.
