Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21948 - Change Continuation Application #721

Merged

Conversation

ArwenQin
Copy link
Collaborator

Issue #: /bcgov/entity#21948

Description of changes:

  • Changed "Continuation In" to "Continuation Application" in create UI

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

ArwenQin and others added 3 commits July 10, 2024 14:03
@ArwenQin ArwenQin requested a review from severinbeauvais July 10, 2024 23:00
@ArwenQin ArwenQin self-assigned this Jul 10, 2024
@ArwenQin
Copy link
Collaborator Author

Create UI after change:
image

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-create-dev--pr-721-t3j7ql6o.web.app

@severinbeauvais
Copy link
Collaborator

Please rebase so that you pick up Karim's latest config change, and check whether the testing-coverage error is now fixed.

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Don't merge until we get Andy's thoughts on the NR request type label.

@ArwenQin
Copy link
Collaborator Author

/gcbrun

@ArwenQin
Copy link
Collaborator Author

Looks good. Don't merge until we get Andy's thoughts on the NR request type label.

Thanks you Severin. I just confirmed with Andy and changed the name request code back.
Rebased.
Could you please double check if we can merge now? Thank you.

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-create-dev--pr-721-t3j7ql6o.web.app

@severinbeauvais severinbeauvais merged commit 4163c81 into bcgov:main Jul 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants