Skip to content

Commit

Permalink
- app version = 4.7.6 (#542)
Browse files Browse the repository at this point in the history
- deleted obsolete "alteration-ui-enabled" FF
- deleted obsolete "change-ui-enabled" FF
- deleted obsolete "conversion-ui-enabled" FF
- removed flag usage from Alteration.vue
- removed flag usage from Change.vue
- removed flag usage from Conversion.vue
- removed flag usage from SpecialResolution.vue
  • Loading branch information
severinbeauvais authored Nov 9, 2023
1 parent e17ff0e commit 8ca35c5
Show file tree
Hide file tree
Showing 7 changed files with 3 additions and 42 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-edit-ui",
"version": "4.7.5",
"version": "4.7.6",
"private": true,
"appName": "Edit UI",
"sbcName": "SBC Common Components",
Expand Down
3 changes: 0 additions & 3 deletions src/utils/feature-flag-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,7 @@ declare const window: any
* Uses "business-edit" project (per LD client id in config).
*/
export const defaultFlagSet: LDFlagSet = {
'alteration-ui-enabled': false,
'banner-text': '', // by default, there is no banner text
'change-ui-enabled': false,
'conversion-ui-enabled': false,
'restoration-ui-enabled': false,
'sentry-enable': false, // by default, no sentry logs
'supported-correction-entities': [],
Expand Down
9 changes: 0 additions & 9 deletions src/views/Alteration.vue
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@
<script lang="ts">
import { Component, Emit, Mixins, Prop, Watch } from 'vue-property-decorator'
import { Action, Getter } from 'pinia-class'
import { GetFeatureFlag } from '@/utils/'
import { AlterationSummary, Articles } from '@/components/Alteration/'
import { BusinessContactInfo, BusinessType, CertifySection, CourtOrderPoa, CurrentDirectors,
DocumentsDelivery, EntityName, FolioInformation, OfficeAddresses, RecognitionDateTime,
Expand Down Expand Up @@ -247,14 +246,6 @@ export default class Alteration extends Mixins(CommonMixin, FeeMixin, FilingTemp
// do not proceed if we are not authenticated (safety check - should never happen)
if (!this.isAuthenticated) return
// do not proceed if FF is disabled
// bypass this when Vitest is running as FF are not fetched
if (!this.isVitestRunning && !GetFeatureFlag('alteration-ui-enabled')) {
window.alert('Alterations are not available at the moment. Please check again later.')
this.$root.$emit('go-to-dashboard', true)
return
}
// try to fetch data
try {
// fetch entity snapshot
Expand Down
9 changes: 0 additions & 9 deletions src/views/Change.vue
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@
<script lang="ts">
import { Component, Emit, Mixins, Prop, Watch } from 'vue-property-decorator'
import { Action, Getter } from 'pinia-class'
import { GetFeatureFlag } from '@/utils/'
import { ChangeSummary } from '@/components/Change/'
import { BusinessContactInfo, BusinessStartDate, BusinessType, CertifySection, CompletingParty, CourtOrderPoa,
DocumentsDelivery, EntityName, NatureOfBusiness, OfficeAddresses, PeopleAndRoles, StaffPayment,
Expand Down Expand Up @@ -190,14 +189,6 @@ export default class Change extends Mixins(CommonMixin, FeeMixin, FilingTemplate
// do not proceed if we are not authenticated (safety check - should never happen)
if (!this.isAuthenticated) return
// do not proceed if FF is disabled
// bypass this when Vitest is running as FF are not fetched
if (!this.isVitestRunning && !GetFeatureFlag('change-ui-enabled')) {
window.alert('Change filings are not available at the moment. Please check again later.')
this.$root.$emit('go-to-dashboard', true)
return
}
// try to fetch data
try {
// fetch entity snapshot
Expand Down
9 changes: 0 additions & 9 deletions src/views/Conversion.vue
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
<script lang="ts">
import { Component, Emit, Mixins, Prop, Watch } from 'vue-property-decorator'
import { Action, Getter } from 'pinia-class'
import { GetFeatureFlag } from '@/utils/'
import { ConversionNOB, ConversionSummary } from '@/components/Conversion'
import { CompletingParty, BusinessStartDate, BusinessType, EntityName, FolioInformation, OfficeAddresses,
PeopleAndRoles, YourCompanyWrapper } from '@/components/common/'
Expand Down Expand Up @@ -138,14 +137,6 @@ export default class Conversion extends Mixins(CommonMixin, FeeMixin, FilingTemp
// do not proceed if we are not authenticated (safety check - should never happen)
if (!this.isAuthenticated) return
// do not proceed if FF is disabled
// bypass this when Vitest is running as FF are not fetched
if (!this.isVitestRunning && !GetFeatureFlag('conversion-ui-enabled')) {
window.alert('Conversion filings are not available at the moment. Please check again later.')
this.$root.$emit('go-to-dashboard', true)
return
}
// do not proceed if user is not staff
const isStaffOnly = this.$route.matched.some(r => r.meta?.isStaffOnly)
if (isStaffOnly && !this.isRoleStaff) {
Expand Down
9 changes: 0 additions & 9 deletions src/views/SpecialResolution.vue
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@
<script lang="ts">
import { Component, Emit, Mixins, Prop, Watch } from 'vue-property-decorator'
import { Action, Getter } from 'pinia-class'
import { GetFeatureFlag } from '@/utils/'
import { SpecialResolutionSummary, Resolution } from '@/components/SpecialResolution'
import { AssociationType, BusinessContactInfo, BusinessType, CertifySection, CompletingParty, CurrentDirectors,
DocumentsDelivery, EntityName, FolioInformation, OfficeAddresses, StaffPayment, TransactionalFolioNumber,
Expand Down Expand Up @@ -231,14 +230,6 @@ export default class SpecialResolution extends Mixins(CommonMixin, FeeMixin, Fil
// do not proceed if we are not authenticated (safety check - should never happen)
if (!this.isAuthenticated) return
// do not proceed if FF is disabled
// bypass this when Vitest is running as FF are not fetched
if (!this.isVitestRunning && !GetFeatureFlag('alteration-ui-enabled')) {
window.alert('Alterations are not available at the moment. Please check again later.')
this.$root.$emit('go-to-dashboard', true)
return
}
// try to fetch data
try {
// fetch entity snapshot
Expand Down

0 comments on commit 8ca35c5

Please sign in to comment.