Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15951 - Special Resolution Correction - QA / UX fixes #509

Merged
merged 11 commits into from
Jul 6, 2023

Conversation

seeker25
Copy link
Collaborator

Issue #: /bcgov/entity#15951

Description of changes:
Special Resolution Correction - QA / UX fixes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #509 (84b7d74) into main (ae09408) will increase coverage by 0.05%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
+ Coverage   86.96%   87.02%   +0.05%     
==========================================
  Files         195      204       +9     
  Lines        3645     3876     +231     
  Branches      444      506      +62     
==========================================
+ Hits         3170     3373     +203     
- Misses        462      489      +27     
- Partials       13       14       +1     
Impacted Files Coverage Δ
src/components/common/EffectiveDateTime.vue 100.00% <ø> (ø)
...omponents/common/PeopleAndRoles/PeopleAndRoles.vue 100.00% <ø> (ø)
src/components/common/YourCompany/index.ts 100.00% <ø> (ø)
src/dialogs/FetchErrorDialog.vue 100.00% <ø> (ø)
src/dialogs/FileAndPayInvalidNameRequestDialog.vue 100.00% <ø> (ø)
src/dialogs/PaymentErrorDialog.vue 100.00% <ø> (ø)
src/dialogs/SaveErrorDialog.vue 100.00% <ø> (ø)
...erfaces/state-interfaces/name-request-interface.ts 100.00% <ø> (ø)
src/resources/LimitedRestorationExtension/BC.ts 100.00% <ø> (ø)
src/resources/LimitedRestorationExtension/BEN.ts 100.00% <ø> (ø)
... and 92 more

... and 2 files with indirect coverage changes

@bcgov bcgov deleted a comment from pwei1018 Jun 30, 2023
@pwei1018
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-509-nje1txxx.web.app

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@seeker25
Copy link
Collaborator Author

seeker25 commented Jul 5, 2023

/gcbrun

@seeker25 seeker25 marked this pull request as ready for review July 5, 2023 18:21
@@ -10,6 +10,8 @@
<v-btn
id="save-btn"
large
outlined
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@pwei1018
Copy link
Collaborator

pwei1018 commented Jul 5, 2023

Temporary Url for review: https://business-edit-dev--pr-509-nje1txxx.web.app

@seeker25 seeker25 merged commit 2bfef59 into bcgov:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants