Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15951 - Changes from UX feedback. #513

Merged
merged 1 commit into from
Jul 12, 2023
Merged

15951 - Changes from UX feedback. #513

merged 1 commit into from
Jul 12, 2023

Conversation

seeker25
Copy link
Collaborator

Issue #: /bcgov/entity#15951

Description of changes:
Add in this style of menu for special resolution:

image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

@seeker25 seeker25 requested a review from Jxio July 12, 2023 01:33
@seeker25 seeker25 self-assigned this Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #513 (76cd785) into main (ae09408) will increase coverage by 0.05%.
The diff coverage is 91.25%.

@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
+ Coverage   86.96%   87.02%   +0.05%     
==========================================
  Files         195      204       +9     
  Lines        3645     3876     +231     
  Branches      444      506      +62     
==========================================
+ Hits         3170     3373     +203     
- Misses        462      489      +27     
- Partials       13       14       +1     
Impacted Files Coverage Δ
src/components/common/EffectiveDateTime.vue 100.00% <ø> (ø)
...omponents/common/PeopleAndRoles/PeopleAndRoles.vue 100.00% <ø> (ø)
src/components/common/YourCompany/index.ts 100.00% <ø> (ø)
src/dialogs/FetchErrorDialog.vue 100.00% <ø> (ø)
src/dialogs/FileAndPayInvalidNameRequestDialog.vue 100.00% <ø> (ø)
src/dialogs/PaymentErrorDialog.vue 100.00% <ø> (ø)
src/dialogs/SaveErrorDialog.vue 100.00% <ø> (ø)
...erfaces/state-interfaces/name-request-interface.ts 100.00% <ø> (ø)
src/resources/LimitedRestorationExtension/BC.ts 100.00% <ø> (ø)
src/resources/LimitedRestorationExtension/BEN.ts 100.00% <ø> (ø)
... and 92 more

... and 2 files with indirect coverage changes

@seeker25 seeker25 merged commit 90b522e into bcgov:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants