Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16800 - Alteration - If a Corporation is changing to CCC -> 3 Director Requirement #515

Merged
merged 6 commits into from
Jul 24, 2023

Conversation

seeker25
Copy link
Collaborator

Issue #: /bcgov/entity#16800

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

@seeker25 seeker25 changed the title 16800 - Alteration - If a Corporation is changing to CCC = 3 Director Requirement 16800 - Alteration - If a Corporation is changing to CCC -> 3 Director Requirement Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #515 (bec1164) into main (e481296) will decrease coverage by 0.05%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   87.11%   87.07%   -0.05%     
==========================================
  Files         207      207              
  Lines        3919     3922       +3     
  Branches      510      510              
==========================================
+ Hits         3414     3415       +1     
- Misses        491      493       +2     
  Partials       14       14              
Impacted Files Coverage Δ
src/store/store.ts 82.68% <0.00%> (-0.23%) ⬇️
...mponents/common/YourCompany/ChangeBusinessType.vue 100.00% <100.00%> (ø)

@seeker25 seeker25 requested a review from Jxio July 20, 2023 22:16
{
value: 'CC',
SHORT_DESC: 'BC Community Contribution Company',
text: 'BC Community Contribution Company'
Copy link
Collaborator

@Jxio Jxio Jul 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropdown options included in src/resources/Alteration/BEN.ts, can be removed here.

@Jxio
Copy link
Collaborator

Jxio commented Jul 20, 2023

looks good to me! maybe wait until #516 get merged.

@seeker25 seeker25 marked this pull request as ready for review July 24, 2023 17:17
@seeker25 seeker25 merged commit 5db6c85 into bcgov:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants