16577 - Alteration - Name Request changes #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #518 +/- ##
==========================================
+ Coverage 87.11% 87.21% +0.10%
==========================================
Files 207 207
Lines 3919 3935 +16
Branches 510 510
==========================================
+ Hits 3414 3432 +18
+ Misses 491 489 -2
Partials 14 14
|
seeker25
changed the title
seeker25
changed the title
| `${GetCorpFullDescription(nr.entity_type_cd)} to ${GetCorpFullDescription(nr.legalType)} ` + | ||
| `does not match the current business type ` + | ||
| `<b>${GetCorpFullDescription(this.getEntityType)}</b>.\n\n` + | ||
| `The Name Request type must match the business type before you can continue.</p>` |
There was a problem hiding this comment.
When using the back-tick for strings, you need to add lines together. You can do this:
dialogContent = `line 1
line 2
line 3`
See if it looks cleaner.
There was a problem hiding this comment.
I'll try this one in the next PR - after QA
There was a problem hiding this comment.
severinbeauvais
approved these changes
Jul 25, 2023
|
Thank you both |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#16577
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).