Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17207 - Alterations - add in new payment code for BC -> ULC #521

Merged
merged 5 commits into from
Jul 27, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Jul 26, 2023

Issue #: /bcgov/entity#17207

Description of changes:
Also includes fixes from previous PR's.

Relies on:
https://github.com/bcgov/bcrs-shared-components/pull/190/files

and a new bcrs-shared enums to be pushed out -^

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

@seeker25 seeker25 self-assigned this Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #521 (d287515) into main (e481296) will increase coverage by 0.10%.
Report is 6 commits behind head on main.
The diff coverage is 99.56%.

@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
+ Coverage   87.11%   87.22%   +0.10%     
==========================================
  Files         207      209       +2     
  Lines        3919     3944      +25     
  Branches      510      511       +1     
==========================================
+ Hits         3414     3440      +26     
+ Misses        491      490       -1     
  Partials       14       14              
Files Changed Coverage Δ
...erfaces/state-interfaces/name-request-interface.ts 100.00% <ø> (ø)
src/resources/Alteration/BC.ts 100.00% <ø> (ø)
src/resources/SpecialResolution/CP.ts 100.00% <ø> (ø)
src/store/state/state-model.ts 100.00% <ø> (ø)
tests/unit/utils.ts 83.33% <83.33%> (ø)
src/App.vue 100.00% <100.00%> (ø)
src/components/Alteration/AlterationSummary.vue 100.00% <100.00%> (ø)
src/components/Alteration/Articles/Articles.vue 100.00% <100.00%> (ø)
...components/Alteration/Articles/ResolutionDates.vue 100.00% <100.00%> (ø)
src/components/Alteration/summary/BusinessType.vue 100.00% <100.00%> (ø)
... and 48 more

@seeker25
Copy link
Collaborator Author

image

@seeker25 seeker25 requested review from Jxio and severinbeauvais July 26, 2023 20:23
@seeker25 seeker25 marked this pull request as ready for review July 26, 2023 20:23
@seeker25
Copy link
Collaborator Author

/gcbrun

@pwei1018
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-521-c5zdlcko.web.app

@seeker25 seeker25 changed the title 17207 - Alterations - Also add in new payment code for BC -> ULC. 17207 - Alterations - add in new payment code for BC -> ULC Jul 27, 2023
Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test util cleanup.

I'll look at this again after the new pay code is published and you've updated the code here.

Copy link
Collaborator

@Jxio Jxio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@seeker25
Copy link
Collaborator Author

/gcbrun

@pwei1018
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-521-c5zdlcko.web.app

@seeker25 seeker25 merged commit 2f3f531 into bcgov:main Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants