-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17207 - Alterations - add in new payment code for BC -> ULC #521
Conversation
Codecov Report
@@ Coverage Diff @@
## main #521 +/- ##
==========================================
+ Coverage 87.11% 87.22% +0.10%
==========================================
Files 207 209 +2
Lines 3919 3944 +25
Branches 510 511 +1
==========================================
+ Hits 3414 3440 +26
+ Misses 491 490 -1
Partials 14 14
|
/gcbrun |
Temporary Url for review: https://business-edit-dev--pr-521-c5zdlcko.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the test util cleanup.
I'll look at this again after the new pay code is published and you've updated the code here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
/gcbrun |
Temporary Url for review: https://business-edit-dev--pr-521-c5zdlcko.web.app |
Issue #: /bcgov/entity#17207
Description of changes:
Also includes fixes from previous PR's.
Relies on:
https://github.com/bcgov/bcrs-shared-components/pull/190/files
and a new bcrs-shared enums to be pushed out -^
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).