17593 Updates for Node 20 #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated Dockerfile - changed vitest environment to jsdom - updated CD script - updated CI script - updated PR script
|
/gcbrun |
|
Temporary Url for review: https://business-edit-dev--pr-531-ukpyb5cw.web.app |
|
I tried this incorporation application. Seems to work without issues! https://business-edit-dev--pr-531-ukpyb5cw.web.app/FM1017608/change?accountid=3040 |
severinbeauvais
requested review from
JazzarKarim,
chenhongjing,
leodube-aot and
jamespaologarcia
and removed request for
leodube-aot
JazzarKarim
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
I've tested a limited restoration extension (https://business-edit-dev--pr-531-ukpyb5cw.web.app/BC0870824/limitedRestorationExtension?restoration-id=146632&accountid=3040), looks good Sev! 👍
leodube-aot
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#17593
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).