Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15863 dividing line approval type #532

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

PaulGarewal
Copy link
Contributor

Issue #: /bcgov/entity#15863

Description of changes:

  • Added v-divider to distinguish between approval type and extension time.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

15863 removed trailing white spaces
@severinbeauvais
Copy link
Collaborator

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-532-fsjbbe3l.web.app

@PaulGarewal
Copy link
Contributor Author

/gcbrun

Copy link
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Paul 👍 Please wait for another approval before merging.

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-532-fsjbbe3l.web.app

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge away.

@PaulGarewal PaulGarewal merged commit 05d30b4 into bcgov:main Sep 27, 2023
5 checks passed
@PaulGarewal PaulGarewal deleted the 15863-dividing-line-approval-type branch September 27, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants