21134 Added continued in entity types to business search #573
Conversation
- imported latest Business Lookup shared component - misc cleanup - renamed getters and session storage key to better match environment key names
| @@ -18,7 +18,7 @@ | |||
| "@bcrs-shared-components/approval-type": "1.0.19", | |||
| "@bcrs-shared-components/base-address": "2.0.3", | |||
| "@bcrs-shared-components/breadcrumb": "2.1.5", | |||
| "@bcrs-shared-components/business-lookup": "1.1.30", | |||
| "@bcrs-shared-components/business-lookup": "1.3.4", | |||
There was a problem hiding this comment.
In this updated component, the default entity types prop now includes C, CBEN, CCC and CUL. (Some business searches use the default; other request specific types only.)
I also diffed the old vs new version of this component and I don't see any breaking changes.
Before (https://dev.edit.business.bcregistry.gov.bc.ca/FM1055550/change?accountid=3040):
After (https://business-edit-dev--pr-573-4h129ls0.web.app/FM1055550/change?accountid=3040):
There was a problem hiding this comment.
I'm playing around with it by adding different types of businesses. Looks good.
There was a problem hiding this comment.
Great, thanks.
The differences between the previous and new versions are: autofocus, removed whitespace, and added props.
Oh, and 4 more entity types in the prop default (link).
|
/gcbrun |
|
In this UI, Business Search is only used in one place: for firm replace corporation. See screenshots above. |
|
Temporary Url for review: https://business-edit-dev--pr-573-4h129ls0.web.app SB says, try this: https://business-edit-dev--pr-573-4h129ls0.web.app/FM1055550/change?accountid=3040 |
Issue #: bcgov/entity#21134
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).