23604 update logic for changing business name #599
Conversation
| @@ -433,24 +433,20 @@ export default class ChangeBusinessType extends Mixins(CommonMixin) { | |||
| submitTypeChange () { | |||
| this.setEntityType(this.selectedEntityType) | |||
| this.isEditingType = false | |||
| if (this.shouldUpdateName()) { | |||
There was a problem hiding this comment.
Using the old logic, we would only update the name and set the NR if the business name had NOT changed. This prevents the case when a user attempts to change the business type (and therefore the name) more than once, as the business name HAS changed in this case.
There was a problem hiding this comment.
Does this logic work on a named company? With and without a new NR?
There was a problem hiding this comment.
Since these changes still retain the check for a numbered business, as before, named companies should not be reaching this block of code below. There should be separate logic that handles named businesses (I can verify where this is if you like).
There was a problem hiding this comment.
Please verify and/or test if you haven't already.
I did a little test on a named BC Limited, and could not change the type to ULC without a NR.
As before, I could not change a named BC to a numbered ULC in one step -- it would take one alteration to change it to numbered, and a second one to change the type. But that's a future ticket so don't worry about it.
There was a problem hiding this comment.
I did a little test on a named BC Limited, and could not change the type to ULC without a NR.
I thought this was the expected behaviour for named businesses? Since altering the business type for a named business would require a name change and this requires an NR.
There was a problem hiding this comment.
Yes, but what if wanted to change my named BC to a numbered ULC? Anyway, we discussed this previously and decided it was low priority right now.
|
/gcbrun |
|
Temporary Url for review: https://business-edit-dev--pr-599-h6gsnubn.web.app Test with: https://business-edit-dev--pr-599-h6gsnubn.web.app/BC0883760/alteration?accountid=3627 |
severinbeauvais
changed the title
|
I did some tests, seems good! |
|
/gcbrun |
Issue #: /bcgov/entity#23604
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).