-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
20947 - Fix limited restoration to full filing saves or resumes with company Name change #606
20947 - Fix limited restoration to full filing saves or resumes with company Name change #606
Conversation
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There is a unit test suite file for EntityName... can you add a test or 2 to verify the scenario you have fixed, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works well!
/gcbrun |
Temporary Url for review: https://business-edit-dev--pr-606-zy7umcr4.web.app |
/gcbrun |
Temporary Url for review: https://business-edit-dev--pr-606-zy7umcr4.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #: /bcgov/entity#20947
Description of changes:
isLimitedRestorationToFull
condition toshouldShowUndoButton
logicnameChangeHandler
to properly handle numbered company namesshouldShowEditedLabel
to include Limited Restoration to Full scenarioNotes:
Test Screenshots:
Test locally with these scenarios:
BC0884776
BC0884805
BC0884873
BC0884875
Before Fix (Using Limited Company as an example):
After Fix:
Scenario 1: Numbered Name
Scenario 2: Non-Numbered Name
Results:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).