Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20947 - Fix limited restoration to full filing saves or resumes with company Name change #606

Conversation

AimeeGao
Copy link
Collaborator

Issue #: /bcgov/entity#20947

Description of changes:

  • Added isLimitedRestorationToFull condition to shouldShowUndoButton logic
  • Enhanced nameChangeHandler to properly handle numbered company names
  • Added logic to set legal name for numbered companies to satisfy Legal API requirement
  • Updated shouldShowEditedLabel to include Limited Restoration to Full scenario

Notes:

  • This is a temporary easy solution until we can implement the refractory long-term fix in ticket #20827

Test Screenshots:
Test locally with these scenarios:

  • CC (Community Contribution Company) BC0884776
  • BC (Limited Company) BC0884805
  • BEN (Benefit Companies) BC0884873
  • ULC (Unlimited Liability Company) BC0884875

Before Fix (Using Limited Company as an example):

  • After using the incorporation number as the name and clicking "save and resume later"
  • Upon resuming, the button incorrectly shows as "Edit"
image

After Fix:

  • Scenario 1: Numbered Name

    • After save and resume, button correctly shows as "Undo"
      image
  • Scenario 2: Non-Numbered Name

    • After save and resume, button correctly shows as "Undo"
      image

Results:

  • Submitted this filing successfully
    image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

@AimeeGao AimeeGao self-assigned this Dec 24, 2024
@AimeeGao
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

bcregistry-sre commented Dec 24, 2024

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There is a unit test suite file for EntityName... can you add a test or 2 to verify the scenario you have fixed, please?

Copy link
Collaborator

@ArwenQin ArwenQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well!

@AimeeGao
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-606-zy7umcr4.web.app

@AimeeGao
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-606-zy7umcr4.web.app

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AimeeGao AimeeGao merged commit f7950db into bcgov:main Dec 24, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants