18284: merge feature branch to main branch (digital business card) #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: CredentialsLanding component: add heading card Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: CredentialsLanding component: add supplemental cards Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: CredentialsLanding component: add image and word wrapping Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: CredentialsLanding component: link styling Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: CredentialsStepper component: deprecate routes Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: CredentialsStepper component: function naming Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: DigitalCredentials component: split into sub components Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: DigitalCredentials component: add web socket component Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: DigitalCredentials component: re-add credential table Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: DigitalCredentials component: update types and imports Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: DigitalCredentials component: add revocation dialogs Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: DigitalCredentials component: add replacement dialogs Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: devcontainer config Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix linting errors Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: bump version number Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: rename route for specificity Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: ran linter and fixed linting errors Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: make interface field optional Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: revert auto-formatting Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: contain dialogs for DigitalCredentials component Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix code smells Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: address code review comments Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: revert autoformatting Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: update wording and styling to align with UX Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix styling Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: feature flag credentials feature with mixin Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: add TOU dialog Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix test failiures and code comments * chore: cleaup Signed-off-by: Akiff Manji <amanji@petridish.dev> * fix: mixin to access digital credential feature Signed-off-by: Akiff Manji <amanji@petridish.dev> * fix: entity menu styling Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: add loading indicators to digital credential route pages Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: reset dialog and functions Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: returl null if undefined Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: beef up conditional checks Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: spelling error Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: spelling error Signed-off-by: Akiff Manji <amanji@petridish.dev> --------- Signed-off-by: Akiff Manji <amanji@petridish.dev>
- added wss://*.gov.bc.ca to connect-src
* refactor: CredentialsLanding component: add heading card Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: CredentialsLanding component: add supplemental cards Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: CredentialsLanding component: add image and word wrapping Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: CredentialsLanding component: link styling Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: CredentialsStepper component: deprecate routes Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: CredentialsStepper component: function naming Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: DigitalCredentials component: split into sub components Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: DigitalCredentials component: add web socket component Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: DigitalCredentials component: re-add credential table Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: DigitalCredentials component: update types and imports Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: DigitalCredentials component: add revocation dialogs Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: DigitalCredentials component: add replacement dialogs Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: devcontainer config Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix linting errors Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: bump version number Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: rename route for specificity Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: ran linter and fixed linting errors Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: make interface field optional Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: revert auto-formatting Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: contain dialogs for DigitalCredentials component Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix code smells Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: address code review comments Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: revert autoformatting Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: update wording and styling to align with UX Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix styling Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: feature flag credentials feature with mixin Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: add TOU dialog Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: fix test failiures and code comments * chore: cleaup Signed-off-by: Akiff Manji <amanji@petridish.dev> * fix: mixin to access digital credential feature Signed-off-by: Akiff Manji <amanji@petridish.dev> * fix: entity menu styling Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: add loading indicators to digital credential route pages Signed-off-by: Akiff Manji <amanji@petridish.dev> * feat: reset dialog and functions Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: returl null if undefined Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: beef up conditional checks Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: spelling error Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: spelling error Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: cleanup spelling and handle edge cases Signed-off-by: Akiff Manji <amanji@petridish.dev> * fix: failing tests Signed-off-by: Akiff Manji <amanji@petridish.dev> * fix: entity menu logic Signed-off-by: Akiff Manji <amanji@petridish.dev> * refactor: remove websocket support in favour of interval polling Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: remove console log Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: address PR comments Signed-off-by: Akiff Manji <amanji@petridish.dev> * chore: remove unused import Signed-off-by: Akiff Manji <amanji@petridish.dev> * fix: build and test failures Signed-off-by: Akiff Manji <amanji@petridish.dev> --------- Signed-off-by: Akiff Manji <amanji@petridish.dev>
|
Kudos, SonarCloud Quality Gate passed!
|
|
/gcbrun |
|
Temporary Url for review: https://business-filings-dev--pr-560-l1buipr2.web.app SB says, try this: https://business-filings-dev--pr-560-l1buipr2.web.app/FM1038931?accountid=2288 (login with BCREG0020) |
|
Akiff, Karim, Argus -- I'm not looking for your review. This is FYI only. |
|
Closing this PR and using #566 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#18284 + bcgov/entity#18394
Description of changes: See PR #552.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).