24001 Updated CI/CD scripts #698
Conversation
- deleted obsolete Makefile - app version = 7.4.0 - added scripts to package.json - updated CD script - updated CI script
| @@ -1,32 +1,29 @@ | |||
| name: BUSINESS FILINGS UI CD | |||
| name: Business Filings UI CD | |||
There was a problem hiding this comment.
.github/workflows/cd.yml
Outdated
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - feature* | ||
| - hotfix * |
There was a problem hiding this comment.
I don't think I need paths here since the UI code is not in a subfolder.
| environment: ${{ inputs.environment }} | ||
| tagname: ${{ inputs.tagname }} | ||
| target: ${{ inputs.target }} | ||
| app_name: "business-filings-ui" |
There was a problem hiding this comment.
As above, I don't think I need working_directory here.
| @@ -1,79 +1,19 @@ | |||
| name: BUSINESS FILINGS UI CI | |||
| name: Business Filings UI CI | |||
There was a problem hiding this comment.
| branches: | ||
| - main | ||
| - feature* | ||
| workflow_dispatch: | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: bash |
There was a problem hiding this comment.
Again, no working_directory here.
| uses: bcgov/bcregistry-sre/.github/workflows/frontend-ci.yaml@main | ||
| with: | ||
| node_version: "20.5.1" | ||
| app_name: "business-filings-ui" |
There was a problem hiding this comment.
Again, no working_directory here.
| uses: bcgov/bcregistry-sre/.github/workflows/frontend-ci.yaml@main | ||
| with: | ||
| node_version: "20.5.1" | ||
| app_name: "business-filings-ui" |
There was a problem hiding this comment.
Also, I didn't include codecov_flag since this is the only project in the codecov.yaml file.
codecov.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| codecov: | |||
| require_ci_to_pass: true | |||
| branch: master | |||
| branch: development | |||
There was a problem hiding this comment.
I don't know if this will work because this repo doesn't have a development branch. (sbc-auth doesn't either and I copied this from there.)
There was a problem hiding this comment.
should be "main". The codecov is broken now. So doesn't matter for now.
Makefile
Outdated
There was a problem hiding this comment.
Obsolete file.
| "private": true, | ||
| "appName": "Filings UI", | ||
| "sbcName": "SBC Common Components", | ||
| "scripts": { | ||
| "dev": "vite", | ||
| "build": "vite build", | ||
| "preview": "vite preview", | ||
| "lint": "eslint . --ext .js,.ts,.vue", | ||
| "build-check": "vite build", |
There was a problem hiding this comment.
I think this, and perhaps some of the others, might be needed by scripts. Anyway, they don't hurt to have here.
| "build-check": "vite build", | ||
| "preview": "vite preview --port 8080", | ||
| "lint": "eslint . --ext js,ts,vue --no-fix", | ||
| "lint:fix": "eslint . --ext js,ts,vue --fix src", |
There was a problem hiding this comment.
I don't want npm run lint to automatically fix issues, so I created "lint:fix" to do that.
This is different from auth-web where the default is to fix and there is "lint:nofix" instead.
codecov.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| codecov: | |||
| require_ci_to_pass: true | |||
| branch: master | |||
| branch: development | |||
There was a problem hiding this comment.
should be "main". The codecov is broken now. So doesn't matter for now.
.github/workflows/cd.yml
Outdated
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - feature* | ||
| - hotfix * |
- removed extra space
|
severinbeauvais
requested review from
pwei1018,
vysakh-menon-aot,
meawong and
ArwenQin
| environment: ${{ inputs.environment }} | ||
| tagname: ${{ inputs.tagname }} | ||
| target: ${{ inputs.target }} | ||
| app_name: "business-filings-ui" |
There was a problem hiding this comment.
By the way, this app_name has to match a section name in 1Password (CD vault), ie:
Issue #: bcgov/entity#24001
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).