Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22639 - Update Certify Section Wording #704

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

ArwenQin
Copy link
Collaborator

Issue #: /bcgov/entity#22639

Description of changes:

  • This is to update the Filing UI Certify Section Wording
  • Filing UI is not using the bcrs shared Certify component, updated the Certify.vue in common folder

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sample:

image

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
@ArwenQin
Copy link
Collaborator Author

/gcbrun

@bcgov bcgov deleted a comment from bcregistry-sre Nov 15, 2024
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-filings-dev--pr-704-12r50d10.web.app

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Did you test it? If it's OK then go ahead and merge 😃

@ArwenQin ArwenQin merged commit 8f568dc into bcgov:main Nov 15, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants