24423 Only redirect when route is Dashboard #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don't redirect to new dashboard for local filings
severinbeauvais
changed the title
|
severinbeauvais
commented
Nov 18, 2024
| @@ -450,9 +450,9 @@ export default class App extends Mixins( | |||
| // now that LaunchDarkly has been updated (ie, in case of user targeting), | |||
| // check whether to use this Entity Dashboard or the new Business Dashboard | |||
| if (GetFeatureFlag('use-business-dashboard')) { | |||
| if (GetFeatureFlag('use-business-dashboard') && (this.$route.name === Routes.DASHBOARD)) { | |||
There was a problem hiding this comment.
This was behaving incorrectly when the (new) Business Dashboard UI redirected to this (old) Entity Dashboard to perform a local filing (eg, COD).
severinbeauvais
commented
Nov 18, 2024
| const identifier = (this.businessId || this.tempRegNumber) | ||
| const dashboardUrl = `${this.getBusinessDashUrl}/${identifier}${this.$route.fullPath}` | ||
| const dashboardUrl = `${this.getBusinessDashUrl}${identifier}${this.$route.fullPath}` |
There was a problem hiding this comment.
The old code caused a double slash between the URL and id.
|
/gcbrun |
|
Temporary Url for review: https://business-filings-dev--pr-705-qcyo3ob5.web.app SB says, try the following examples:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#24423
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).