24657 - Notice of Withdrawal filing

[ArwenQin]

Issue #: /bcgov/entity#24657

Description of changes:

• Create the NOW Filing Page
• 4 new components: Record to be withdrawn, Court Order and POA, Folio/Ref Number, Staff Payment
  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

[ArwenQin]

Updated the format per design, so needed to update the CertifyText for all business types

[ArwenQin]

Test:
https://business-filings-dev--pr-707-i7dbekyt.web.app/BC0883739/notice-of-withdrawal?filingToBeWithdrawn=153004&filingId=0

[ArwenQin]

In Figma, it is 24px

Agree. 24 px looks better. I updated the space to py-6

[ArwenQin]

Although in design, the default font size is 16 px; I think the actual default font size should be 14-px, consistent with other filings

Currently I use 14-px, which is the same as other filings

[severinbeauvais]

The page looks very good.

I think there's still too much whitespace around some components (and not enough between others).

I am unable to save the filing and cannot test resume.

Let's concentrate on what it will take to finish this ticket asap, and then we'll create follow-up tickets for more changes or fixes.

[ArwenQin]

Removed the folio/reference number section.
Updated the space.
Ready to merge.

[ArwenQin]

/gcbrun

[sonarqubecloud]

Quality Gate failed

Failed conditions
23.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[bcregistry-sre]

Temporary Url for review: https://business-filings-dev--pr-707-i7dbekyt.web.app

Sample: https://business-filings-dev--pr-707-i7dbekyt.web.app/BC0883739/notice-of-withdrawal?filingToBeWithdrawn=153004&filingId=0

[severinbeauvais]

This filing is blocked by a missing fee code (see ticket 24959) and some Legal API work. Extra work related to those can be done in a future ticket.

However, in this ticket, I'd like to see an updated JSON object on save.

Also, I'd like to see save and resume working. Since you'd only be saving a draft, Legal API should not be performing schema validation. Right now, as staff, I'm still getting a HTTP 401 (not authorized) when trying to save a draft.

[severinbeauvais]

LGTM. There are some blockers (other tickets) and there's a follow-on UI ticket to finish this.

[eason-pan-bc]

LTGM, like Sev mentioned, we'll need some follow-up tickets to finish it.

[eason-pan-bc]

Just realize one issue in the payload for the filing. the filingId under noticeOfWithdrawal should be int instead of string.

Should be this:

"noticeOfWithdrawal": {
            "filingId": 155118
        }

Not this:

"noticeOfWithdrawal": {
            "filingId": "155118"
        }

Otherwise, you won't able to pass the schema check. https://github.com/bcgov/business-schemas/blob/main/src/registry_schemas/schemas/notice_of_withdrawal.json#L17C1-L18C39

I will repost this to the grooming ticket.

[ArwenQin]

I will update the filingId in the next ticket #24953