24953 - Update NoW Filing Page

[ArwenQin]

Issue #: /bcgov/entity#24953

Description of changes:

• Move the 2 POA check boxes to the first section + add the 2 properties in filing json
• Show the warning message and disable "Submit" when "POA has taken effect" is selected
• Change Court Order section to a common one
• Change the withdrawn filingId to a number (previously string)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

[ArwenQin]

/gcbrun

[ArwenQin]

Updated first section, with 2 check boxes and the warning message:

Disable the "Submit" button when "POA has taken effect" is selected

[bcregistry-sre]

Temporary Url for review: https://business-filings-dev--pr-708-ofasgl8t.web.app

[ArwenQin]

Sample filing json

{
    "header": {
        "name": "noticeOfWithdrawal",
        "certifiedBy": "AQ",
        "email": "eason.pan@gov.bc.ca",
        "date": "2024-12-18",
        "documentOptionalEmail": "test@test.ca",
        "routingSlipNumber": "123456798",
        "priority": false
    },
    "business": {
        "foundingDate": "2024-12-10T23:37:44.000+00:00",
        "identifier": "BC0883809",
        "legalName": "0883809 B.C. LTD.",
        "legalType": "BC"
    },
    "noticeOfWithdrawal": {
        "filingId": 155118,
        "partOfPoa": false,
        "hasTakenEffect": false,
        "courtOrder": {
            "fileNumber": "TT0010045",
            "effectOfOrder": "planOfArrangement"
        }
    }
}

[ArwenQin]

Test: https://business-filings-dev--pr-708-ofasgl8t.web.app/BC0883809/notice-of-withdrawal?filingToBeWithdrawn=155118&filingId=0

The Save and Resume issue is not fixed yet

[severinbeauvais]

Updated first section, with 2 check boxes and the warning message:

Looks great! Please increase the whitespace between the bottom of the warning box and the section frame. (Same whitespace all around.) fixed now, thanks!

[severinbeauvais]

Please increase the whitespace between the bottom of the warning box and the section frame. (Same whitespace all around.)

Please check the whitespace in the other sections, too. I see some inconsistencies. fixed now, thanks!

Eg,

[severinbeauvais]

Looks good so far.

Ask Jacqueline to have a look at this, in case she wants to tweak anything.

[ArwenQin]

/gcbrun

[ArwenQin]

Updated the spaces around first section:

and Staff Payment

All sections are consistent now: py-8 px-5

[severinbeauvais]

This looks good to me, but I'm hoping you can fix the resume issue in this PR also. fixed now, thanks!

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.8% Duplication on New Code

See analysis details on SonarQube Cloud

[ArwenQin]

/gcbrun

[severinbeauvais]

Pre-approved (assuming resume now works correctly). Good work! :)

[bcregistry-sre]

Temporary Url for review: https://business-filings-dev--pr-708-ofasgl8t.web.app

[eason-pan-bc]

LGTM, I tried the link to resume the draft and it worked. (draft filing_id 155239) https://business-filings-dev--pr-708-ofasgl8t.web.app/BC0883809/notice-of-withdrawal?filingToBeWithdrawn=155118&filingId=155239

Update: the 'Resume' button on the dashboard still not working.

[ArwenQin]

Jacqueline has an update for the certify section:

I will update it now, and then we can merge it

[ArwenQin]

Jacqueline said it's not a requirement now, changed the design back. No updates needed. This PR is ready to merge.

[meawong]

Looks good to go!