Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 24953 - Update NoW Per New Designs #709

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

ArwenQin
Copy link
Collaborator

Issue #: /bcgov/entity#24953

Description of changes:

  • remove POA section text
  • add an icon in submit button
  • change document delivery section label
  • Other changes are pending, discussing with Jacqueline

Jacqueline's UX assurance notes are here:
https://www.figma.com/design/CLqwqGQYARaSrnzLwh6w8Q/Notice-of-Withdrawal?node-id=700-16551&p=f&focus-id=2462-239471&m=dev

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
@ArwenQin
Copy link
Collaborator Author

@ArwenQin
Copy link
Collaborator Author

  1. remove POA section text
    image

  2. add an icon in submit button
    image

  3. change document delivery section label (Registered Office)
    image

Other changes are pending, discussing with Jacqueline

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one thing: use the error class on the inner div (not outer div) to fix the red bar:

image

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
@ArwenQin
Copy link
Collaborator Author

/gcbrun

@bcgov bcgov deleted a comment from bcregistry-sre Dec 23, 2024
@ArwenQin
Copy link
Collaborator Author

Looks good. Just one thing: use the error class on the inner div (not outer div) to fix the red bar:

image

Updated! looks good now

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-filings-dev--pr-709-473wrfuv.web.app

Copy link
Collaborator

@meawong meawong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the fix!

Copy link
Collaborator

@eason-pan-bc eason-pan-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@ArwenQin
Copy link
Collaborator Author

Thanks reviewers. I want to confirm with Jacqueline tmr and then merge the changes.

@ArwenQin ArwenQin merged commit b7ddbaf into bcgov:main Dec 24, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants