Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/API: Create CI workflow triggered on PR #35

Merged
merged 8 commits into from
Oct 25, 2023
Merged

Conversation

patrickpeinanw
Copy link
Collaborator

@patrickpeinanw patrickpeinanw commented Oct 24, 2023

*Issue:*bcgov/entity#18133
*Issue:*bcgov/entity#18134

Description of changes:

Create CI workflow triggered on PR for UI (btr-web) and API (btr-api)
The jobs will run for all three UI projects (btr-common-components, btr-layouts, btr-main-app)

  • run lint and fail on any errors or warnings
  • run test and fail / display errors
  • run build
  • run test coverage fail if under 80% (This one is not working now. The test coverage result is displayed in the console, but the report cannot be submitted to Codecov. I will look into this)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@codecov
Copy link

codecov bot commented Oct 25, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@kialj876
Copy link
Collaborator

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-btr-dev--pr-35-j9zbi5k8.web.app

Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Patrick nice work 👍

Just a couple comments

.github/workflows/btr-ui-ci.yml Outdated Show resolved Hide resolved
.github/workflows/btr-ui-ci.yml Show resolved Hide resolved
@patrickpeinanw patrickpeinanw changed the title UI: Create CI workflow triggered on PR UI/API: Create CI workflow triggered on PR Oct 25, 2023
@kialj876 kialj876 merged commit dd8b16d into bcgov:main Oct 25, 2023
12 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants