breadcrumb layout / middleware updates #51
Conversation
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #51 +/- ##
=======================================
Coverage ? 94.58%
=======================================
Files ? 9
Lines ? 388
Branches ? 23
=======================================
Hits ? 367
Misses ? 0
Partials ? 21
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
Still adding tests / cleaning up |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-btr-dev--pr-51-kx8hvn0o.web.app |
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
|
/gcbrun |
| @@ -2,6 +2,7 @@ describe('forms -> email -> validate that email component work inside example fo | |||
| beforeEach(() => { | |||
| // navigate to index page and check footer and header exist | |||
| cy.visit('/examples/form') | |||
| cy.wait(2000) | |||
There was a problem hiding this comment.
for some reason this is required now with the middleware getting invoked (I think its due to cypress not having a hydration hook or something like that)
|
Temporary Url for review: https://bcregistry-btr-dev--pr-51-kx8hvn0o.web.app |
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-btr-dev--pr-51-kx8hvn0o.web.app |
*Issue:*bcgov/entity#18320
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).