Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18359 filing control #59

Merged
merged 3 commits into from
Nov 23, 2023
Merged

18359 filing control #59

merged 3 commits into from
Nov 23, 2023

Conversation

kialj876
Copy link
Collaborator

*Issue:*bcgov/entity#18359

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
@kialj876 kialj876 self-assigned this Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@d43c5bc). Click here to learn what that means.

❗ Current head f0473ba differs from pull request most recent head 5cfdbec. Consider uploading reports for the commit 5cfdbec to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage        ?   91.43%           
=======================================
  Files           ?       13           
  Lines           ?      654           
  Branches        ?       26           
=======================================
  Hits            ?      598           
  Misses          ?       32           
  Partials        ?       24           
Flag Coverage Δ
btr-ui 91.43% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kialj876
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-btr-dev--pr-59-fw2uhmow.web.app

Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
@kialj876 kialj876 merged commit bdbfd4a into bcgov:main Nov 23, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants